fix: str_replace_all() error with named input and function replacement#605
Closed
LeonidasZhak wants to merge 1 commit into
Closed
fix: str_replace_all() error with named input and function replacement#605LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
When str_replace_all() receives a named character vector and a function replacement, and the pattern matches multiple times per element, it errors because vctrs::list_unchop() can't propagate outer names to inner vectors with length > 1. Fix: save names before processing, use unname(old) in list_unchop(), and restore names after replacement. Fixes #595
Author
|
Withdrawing this because checks are failing and I should not ask maintainers to review an unready automated PR. Sorry for the noise, and thank you for maintaining stringr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595
Problem
str_replace_all()errors when all three conditions are met:stringis a named character vectorreplacementis a functionRoot Cause
str_transform_all()passes the named list fromstr_sub_all()directly tovctrs::list_unchop(), which can't propagate outer names when inner vectors have length > 1. This was introduced when the function switched fromunlist()tolist_unchop().Fix
Three minimal changes in
str_transform_all()(R/replace.R):names(string)before processingunname(old)inlist_unchop()Tests
FAIL: 0 | WARN: 0 | SKIP: 39 | PASS: all remaining